Skip to content

Do not module reset or load prod_util when running ecflow#4667

Draft
DavidHuber-NOAA wants to merge 1 commit intoNOAA-EMC:dev/gfs.v17from
DavidHuber-NOAA:fix/ecf_v17
Draft

Do not module reset or load prod_util when running ecflow#4667
DavidHuber-NOAA wants to merge 1 commit intoNOAA-EMC:dev/gfs.v17from
DavidHuber-NOAA:fix/ecf_v17

Conversation

@DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Mar 17, 2026

Description

When running ecflow, loading prod_util causes issues with the suite (it should only be loaded in the ecf scripts). Similarly, modules should not be reset when running ecflow cases as this will cause prod_util to be unloaded.

Resolves #4599

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES
    • GDASApp

How has this been tested?

@lgannoaa is testing this change presently.
I also verified that setting ECF_JOB and then loading the modules prevented prod_util from loading.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes

@DavidHuber-NOAA DavidHuber-NOAA added the needs submodule update Requires submodule PRs to be merged label Mar 17, 2026
@DavidHuber-NOAA
Copy link
Contributor Author

This PR requires a GDASApp update, hence the needs submodule update label. Once the GDASApp PR is open, I will open this PR for review.

@DavidHuber-NOAA
Copy link
Contributor Author

@lgannoaa did this work successfully for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs submodule update Requires submodule PRs to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant